Fix CI #1913
Open
Fix CI #1913
+46
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`%ERRORLEVEL%` in an if-condition is expanded too early `SetLocal EnableDelayedExpansion` + `!ERRORLEVEL!` works in principle, but changes which folder the if-condition is actually executed in, so it's simpler to use `||`.
h-vetinari
requested review from
cpcloud,
jakirkham,
jreback,
kou,
kszucs,
leifwalsh,
nealrichardson,
pcmoritz,
pearu,
pitrou,
raulcd,
robertnishihara,
siddharthteotia,
wesm and
xhochy
as code owners
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21053965686. Examine the logs at this URL for more detail. |
Member
|
The linux/macOS failures are related to Azure, could this be a problem with Azurite as in: I fixed this by pinning nodejs>=16 The TZ failures are a whole different beast :) |
This was referenced Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently failing on all platforms; on unix we get
whereas on windows the errors are predominantly due to missing a tzdb. Windows has apparently been failing for longer already, but this had been hidden behind an expansion bug. We need something like apache/arrow#48874 here.